Sticky navbar #569
Merged
Sticky navbar #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amilajack
approved these changes
Apr 20, 2019
amilajack
pushed a commit
that referenced
this pull request
Apr 21, 2019
* v1.3.3 (#570) * bump to v1.3.3 * Sticky navbar (#569) * collapse toggler on click * sticky navbar * remove custom scrollbar styling to fix padding issues with container * Remove dead code * onChange is a class method * initInfinitePagination as arrow to avoid explicit binding * component is already aware of redux, no need to bindActionCreators * Only import what's needed
amilajack
pushed a commit
that referenced
this pull request
Apr 21, 2019
* v1.3.3 (#570) * bump to v1.3.3 * Sticky navbar (#569) * collapse toggler on click * sticky navbar * remove custom scrollbar styling to fix padding issues with container * Remove dead code * onChange is a class method * initInfinitePagination as arrow to avoid explicit binding * component is already aware of redux, no need to bindActionCreators * Only import what's needed
amilajack
added a commit
that referenced
this pull request
Apr 21, 2019
* Tidy up home component (#571) * v1.3.3 (#570) * bump to v1.3.3 * Sticky navbar (#569) * collapse toggler on click * sticky navbar * remove custom scrollbar styling to fix padding issues with container * Remove dead code * onChange is a class method * initInfinitePagination as arrow to avoid explicit binding * component is already aware of redux, no need to bindActionCreators * Only import what's needed * fix subtitles (#572) fix subtitles, add multi-lang subtitle support * semver bump to 1.3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #567
Actually making it sticky, instead of fixed since sticky avoids having to set padding/margin to the body.
Also implemented logic for the collapsed menu, that wasn't working for me